[
https://issues.apache.org/jira/browse/HADOOP-18196?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17522853#comment-17522853
]
Viraj Jasani commented on HADOOP-18196:
---------------------------------------
Thanks for your reviews [~ste...@apache.org] [~tasanuma] !
> Remove replace-guava from replacer plugin
> -----------------------------------------
>
> Key: HADOOP-18196
> URL: https://issues.apache.org/jira/browse/HADOOP-18196
> Project: Hadoop Common
> Issue Type: Task
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Fix For: 3.4.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
> While running the build, realized that all replacer plugin executions run
> only after "banned-illegal-imports" enforcer plugin.
> For instance,
> {code:java}
> [INFO] --- maven-enforcer-plugin:3.0.0:enforce (banned-illegal-imports) @
> hadoop-cloud-storage ---
> [INFO]
> [INFO] --- replacer:1.5.3:replace (replace-generated-sources) @
> hadoop-cloud-storage ---
> [INFO] Skipping
> [INFO]
> [INFO] --- replacer:1.5.3:replace (replace-sources) @ hadoop-cloud-storage ---
> [INFO] Skipping
> [INFO]
> [INFO] --- replacer:1.5.3:replace (replace-guava) @ hadoop-cloud-storage ---
> [INFO] Replacement run on 0 file.
> [INFO] {code}
> Hence, if our source code uses com.google.common, banned-illegal-imports will
> cause the build failure and replacer plugin would not even get executed.
> We should remove it as it is only redundant execution step.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
