mccormickt12 commented on code in PR #4181:
URL: https://github.com/apache/hadoop/pull/4181#discussion_r851542051
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java:
##########
@@ -81,6 +88,19 @@ enum ResultKind {
private List<RegexMountPoint<T>> regexMountPointList =
new ArrayList<RegexMountPoint<T>>();
+ private final boolean isNestedMountPointSupported;
+ private Set<LinkEntry> sortedLinkEntries = new TreeSet<>((o1, o2) -> {
Review Comment:
its a little weird that `sortedLinkEntries` is a private member, but only
used in `getLinkEntries` which just does an `addAll` and return. I think we
should probably get rid of this as a member.
otherwise we need to consider clearing the set. It also just seems like an
unnecessary memory overhead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
