steveloughran commented on code in PR #2584:
URL: https://github.com/apache/hadoop/pull/2584#discussion_r853282822
##########
hadoop-tools/hadoop-streaming/src/main/java/org/apache/hadoop/streaming/mapreduce/StreamInputFormat.java:
##########
@@ -62,14 +58,8 @@ public RecordReader<Text, Text>
createRecordReader(InputSplit genericSplit,
context.progress();
// Open the file and seek to the start of the split
- Path path = split.getPath();
- FileSystem fs = path.getFileSystem(conf);
- // open the file
- final FutureDataInputStreamBuilder builder = fs.openFile(path);
- FutureIOSupport.propagateOptions(builder, conf,
- MRJobConfig.INPUT_FILE_OPTION_PREFIX,
- MRJobConfig.INPUT_FILE_MANDATORY_PREFIX);
- FSDataInputStream in = FutureIOSupport.awaitFuture(builder.build());
+ FileSystem fs = split.getPath().getFileSystem(conf);
+ FSDataInputStream in = fs.open(split.getPath());
Review Comment:
good q. not sure why i reverted (accidentally?). reverted back.
FWIW, hadoop-streaming is a module i don't think gets used any more, not now
we have things like flnk. cutting it would be good
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
