[
https://issues.apache.org/jira/browse/HADOOP-18172?focusedWorklogId=758892&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-758892
]
ASF GitHub Bot logged work on HADOOP-18172:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 19/Apr/22 23:52
Start Date: 19/Apr/22 23:52
Worklog Time Spent: 10m
Work Description: xinglin commented on code in PR #4106:
URL: https://github.com/apache/hadoop/pull/4106#discussion_r853610752
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java:
##########
@@ -458,11 +458,11 @@ private boolean hasFallbackLink() {
* there will be root to root mapping. So, root does not represent as
* internalDir.
*/
- protected boolean isRootInternalDir() {
+ public boolean isRootInternalDir() {
Review Comment:
We checked methods from InodeTree that are being used in ViewFileSystem.
resolve() and getHomeDirPrefixValue() are the other two methods which are also
being used in ViewFileSystem, besides the constructor of InodeTree. Thus, we
also made these two methods public.
Issue Time Tracking
-------------------
Worklog Id: (was: 758892)
Time Spent: 3h 20m (was: 3h 10m)
> Change scope of getRootFallbackLink for InodeTree to make them accessible
> from outside package
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-18172
> URL: https://issues.apache.org/jira/browse/HADOOP-18172
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Xing Lin
> Assignee: Xing Lin
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> Sometimes, we need to access rootFallBackLink in InodeTree from another
> package. One such case is we extend from ViewFileSystem but want to put the
> new filesystem in org.apache.hadoop.fs package, instead of
> org.apache.hadoop.fs.viewfs package. As a result, we need make them public,
> similar as what we did for getMountPoints() in HADOOP-18100.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
