tomscut commented on code in PR #4186:
URL: https://github.com/apache/hadoop/pull/4186#discussion_r853655682
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/blockmanagement/DatanodeManager.java:
##########
@@ -366,6 +365,21 @@ public class DatanodeManager {
DFSConfigKeys.DFS_NAMENODE_BLOCKS_PER_POSTPONEDBLOCKS_RESCAN_KEY_DEFAULT);
}
+ /**
+ * Determines whether slow peer tracker should be enabled. If
dataNodePeerStatsEnabledVal is
+ * true, slow peer tracker is initialized.
+ *
+ * @param conf The configuration to use while initializing slowPeerTracker.
+ * @param timer Timer object for slowPeerTracker.
+ * @param dataNodePeerStatsEnabledVal To determine whether slow peer
tracking should be enabled.
+ */
+ public void initSlowPeerTracker(Configuration conf, Timer timer,
+ boolean dataNodePeerStatsEnabledVal) {
+ this.dataNodePeerStatsEnabled = dataNodePeerStatsEnabledVal;
+ this.slowPeerTracker = dataNodePeerStatsEnabled ?
+ new SlowPeerTracker(conf, timer) : null;
Review Comment:
If this.slowPeerTracker is set to null, may cause NPE.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
