xinglin commented on code in PR #4144:
URL: https://github.com/apache/hadoop/pull/4144#discussion_r854554335
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java:
##########
@@ -410,7 +410,16 @@ private boolean hasFallbackLink() {
return rootFallbackLink != null;
}
- protected INodeLink<T> getRootFallbackLink() {
+ /**
+ * @return true if the root represented as internalDir. In LinkMergeSlash,
+ * there will be root to root mapping. So, root does not represent as
+ * internalDir.
+ */
+ public boolean isRootInternalDir() {
Review Comment:
We found HDFS-15529 added this method (isRootInternalDir) with a few other
changes to getChildFileSystem in ViewFileSystem. Unfortunately, new changes
have been made since HDFS-15529 and made its pull request out-of-date
(targetFileSystem in InodeLink is now private, instead of package private).
Besides, file TestViewFileSystemOverloadSchemeWithHdfsScheme.java does not
exist in branch-2.10 yet. So, we decide to leave out isRootInternalDir() for
this PR.
PR for HDFS-15529:
https://github.com/apache/hadoop/pull/2234
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
