[
https://issues.apache.org/jira/browse/HADOOP-18172?focusedWorklogId=759580&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-759580
]
ASF GitHub Bot logged work on HADOOP-18172:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Apr/22 21:06
Start Date: 20/Apr/22 21:06
Worklog Time Spent: 10m
Work Description: xinglin commented on code in PR #4144:
URL: https://github.com/apache/hadoop/pull/4144#discussion_r854554335
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/viewfs/InodeTree.java:
##########
@@ -410,7 +410,16 @@ private boolean hasFallbackLink() {
return rootFallbackLink != null;
}
- protected INodeLink<T> getRootFallbackLink() {
+ /**
+ * @return true if the root represented as internalDir. In LinkMergeSlash,
+ * there will be root to root mapping. So, root does not represent as
+ * internalDir.
+ */
+ public boolean isRootInternalDir() {
Review Comment:
We found HDFS-15529 added this method (isRootInternalDir) with a few other
changes to getChildFileSystem in ViewFileSystem. Unfortunately, new changes
have been made since HDFS-15529 and made its pull request out-of-date
(targetFileSystem in InodeLink is now private, instead of package private).
Besides, file TestViewFileSystemOverloadSchemeWithHdfsScheme.java does not
exist in branch-2.10 yet. So, we decide to leave out isRootInternalDir() for
this PR.
PR for HDFS-15529:
https://github.com/apache/hadoop/pull/2234
Issue Time Tracking
-------------------
Worklog Id: (was: 759580)
Time Spent: 5h 20m (was: 5h 10m)
> Change scope of getRootFallbackLink for InodeTree to make them accessible
> from outside package
> ----------------------------------------------------------------------------------------------
>
> Key: HADOOP-18172
> URL: https://issues.apache.org/jira/browse/HADOOP-18172
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Xing Lin
> Assignee: Xing Lin
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.4.0, 3.3.4
>
> Time Spent: 5h 20m
> Remaining Estimate: 0h
>
> Sometimes, we need to access rootFallBackLink in InodeTree from another
> package. One such case is we extend from ViewFileSystem but want to put the
> new filesystem in org.apache.hadoop.fs package, instead of
> org.apache.hadoop.fs.viewfs package. As a result, we need make them public,
> similar as what we did for getMountPoints() in HADOOP-18100.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
