hchaverri commented on code in PR #4092:
URL: https://github.com/apache/hadoop/pull/4092#discussion_r856427800
##########
hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/security/token/delegation/TestDelegationToken.java:
##########
@@ -579,4 +634,85 @@ public void testEmptyToken() throws IOException {
assertEquals(token1, token2);
assertEquals(token1.encodeToUrlString(), token2.encodeToUrlString());
}
+
+ @Test
+ public void testDelegationTokenSecretManagerMetrics() throws Exception {
+ TestDelegationTokenSecretManager dtSecretManager =
+ new TestDelegationTokenSecretManager(24*60*60*1000,
+ 10*1000, 1*1000, 60*60*1000);
+ try {
+ dtSecretManager.startThreads();
+
+ final Token<TestDelegationTokenIdentifier> token =
callAndValidateMetrics(
+ dtSecretManager, dtSecretManager.getMetrics().getStoreToken(),
"storeToken",
+ () -> generateDelegationToken(dtSecretManager, "SomeUser",
"JobTracker"), 1);
+
+ callAndValidateMetrics(dtSecretManager,
dtSecretManager.getMetrics().getUpdateToken(),
+ "updateToken", () -> dtSecretManager.renewToken(token,
"JobTracker"), 1);
+
+ callAndValidateMetrics(dtSecretManager,
dtSecretManager.getMetrics().getRemoveToken(),
+ "removeToken", () -> dtSecretManager.cancelToken(token,
"JobTracker"), 1);
+ } finally {
+ dtSecretManager.stopThreads();
+ }
+ }
+
+ @Test
+ public void testDelegationTokenSecretManagerMetricsFailures() throws
Exception {
+ int errorSleepMillis = 200;
+ TestFailureDelegationTokenSecretManager dtSecretManager =
+ new TestFailureDelegationTokenSecretManager(errorSleepMillis);
+
+ try {
+ dtSecretManager.startThreads();
+
+ final Token<TestDelegationTokenIdentifier> token =
+ generateDelegationToken(dtSecretManager, "SomeUser", "JobTracker");
+
+ dtSecretManager.setThrowError(true);
+
+ callAndValidateFailureMetrics(dtSecretManager, "storeToken", 1, 1, false,
+ errorSleepMillis,
+ () -> generateDelegationToken(dtSecretManager, "SomeUser",
"JobTracker"));
+
+ callAndValidateFailureMetrics(dtSecretManager, "updateToken", 1, 2, true,
+ errorSleepMillis, () -> dtSecretManager.renewToken(token,
"JobTracker"));
+
+ callAndValidateFailureMetrics(dtSecretManager, "removeToken", 1, 3, true,
+ errorSleepMillis, () -> dtSecretManager.cancelToken(token,
"JobTracker"));
+ } finally {
+ dtSecretManager.stopThreads();
+ }
+ }
+
+ private <T> T callAndValidateMetrics(TestDelegationTokenSecretManager
dtSecretManager,
+ MutableRate metric, String statName, Callable<T> callable, int
expectedCount)
+ throws Exception {
+ MeanStatistic stat = IOStatisticAssertions.lookupMeanStatistic(
+ dtSecretManager.getMetrics().getIoStatistics(), statName + ".mean");
+ Assert.assertEquals(expectedCount - 1, metric.lastStat().numSamples());
+ Assert.assertEquals(expectedCount - 1, stat.getSamples());
+ T returnedObject = callable.call();
+ Assert.assertEquals(expectedCount, metric.lastStat().numSamples());
Review Comment:
I've updated to use assertEquals() only
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
