[ 
https://issues.apache.org/jira/browse/HADOOP-18198?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17526822#comment-17526822
 ] 

Ayush Saxena commented on HADOOP-18198:
---------------------------------------

{quote}1. where did you run the build from
{quote}
On my Mac, using the command given in the doc, with all those arguments. like 
--docker --dockercache. So it was running inside docker only.
{quote}2. should we go with this as the RC?
{quote}
Thats your call, If you want to give it a try next week. I am ok with that. I 
see you wanted to get HDFS-16453 in as well. 
{quote}we will have to make the docker build configurable to at least 
optionally turn off http keepalives in maven builds.
{quote}
If you think some maven arguments, can fix things for you. Can try this:
{noformat}
diff --git a/dev-support/bin/create-release b/dev-support/bin/create-release
index 0ba55e7e957..77c64bb10e6 100755
--- a/dev-support/bin/create-release
+++ b/dev-support/bin/create-release
@@ -293,6 +293,7 @@ function usage
   echo "--security              Emergency security release"
   echo "--sign                  Use .gnupg dir to sign the artifacts and jars"
   echo "--version=[version]     Use an alternative version string"
+  echo "--mvnargs=[args]        Extra Maven args to be provided when running 
mvn commands"
 }
 
 function option_parse
@@ -347,6 +348,9 @@ function option_parse
       --version=*)
         HADOOP_VERSION=${i#*=}
       ;;
+      --mvnargs=*)
+        MVNEXTRAARGS=${i#*=}
+      ;;
     esac
   done
 
@@ -413,6 +417,9 @@ function option_parse
       MVN_ARGS=("-Dmaven.repo.local=${MVNCACHE}")
     fi
   fi
+  if [ -n "$MVNEXTRAARGS" ]; then
+    MVN_ARGS+=("$MVNEXTRAARGS")
+    fi
 
   if [[ "${SECURITYRELEASE}" = true ]]; then
     if [[ ! -d 
"${BASEDIR}/hadoop-common-project/hadoop-common/src/site/markdown/release/${HADOOP_VERSION}"
 ]]; then
{noformat}
And then can shoot a command like this:
{noformat}
dev-support/bin/create-release --asfrelease --docker --dockercache 
--mvnargs="-Dhttp.keepAlive=false -Dmaven.wagon.http.pool=false"{noformat}
I didn't try this change in full, but the maven arg was there in the install 
command:
{noformat}
$ /usr/bin/mvn -Dmaven.repo.local=/maven -Dhttp.keepAlive=false 
-Dmaven.wagon.http.pool=false -pl hadoop-maven-plugins -am clean install > 
/build/source/patchprocess/mvn_install_maven_plugins.log 2>&1
$ /usr/bin/mvn -Dmaven.repo.local=/maven -Dhttp.keepAlive=false 
-Dmaven.wagon.http.pool=false clean > /build/source/patchprocess/mvn_clean.log 
2>&1
$ mkdir -p /build/source/target/artifacts
..
..
$ /usr/bin/mvn -Dmaven.repo.local=/maven -Dhttp.keepAlive=false 
-Dmaven.wagon.http.pool=false apache-rat:check > 
/build/source/patchprocess/mvn_apache_rat.log 2>&1
..
..
$ /usr/bin/mvn -Dmaven.repo.local=/maven -Dhttp.keepAlive=false 
-Dmaven.wagon.http.pool=false deploy -Pdist,src,yarn-ui -Psign 
-Dgpg.useagent=true -Dgpg.executable=/usr/bin/gpg -DskipTests -Dtar -Pnative 
-Drequire.snappy -Drequire.openssl -Drequire.fuse > 
/build/source/patchprocess/mvn_deploy.log 2>&1

{noformat}

> Release Hadoop 3.3.3: hadoop-3.3.2 with some fixes
> --------------------------------------------------
>
>                 Key: HADOOP-18198
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18198
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: build
>    Affects Versions: 3.3.2
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Hadoop 3.3.3 is a minor followup release to Hadoop 3.3.2 with all the 
> incremental changes which went in to the 3.2.4 release
> * minor CVE fixes in Hadoop source
> * CVE fixes in dependencies we know of (protobuf unmarshalling leading to 
> DoS, jackson stack overflow,...)
> * replacement of log4j 1.2.17 to reload4j
> * node.js update
> This is not a release off branch-3.3, it is a fork of 3.3.2 with the changes.
> The next release of branch-3.3 will be numbered hadoop-3.3.4; updating maven 
> versions and JIRA fix versions is part of this release process.
> The changes here are already in branch 3.2.4; this completes the set
> CVEs fixed
> * CVE-2022-26612: Apache Hadoop: Arbitrary file write in 
> FileUtil#unpackEntries on Windows (HADOOP-18155)



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to