[ https://issues.apache.org/jira/browse/HADOOP-18175?focusedWorklogId=762181&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-762181 ]
ASF GitHub Bot logged work on HADOOP-18175: ------------------------------------------- Author: ASF GitHub Bot Created on: 26/Apr/22 08:58 Start Date: 26/Apr/22 08:58 Worklog Time Spent: 10m Work Description: ahmarsuhail commented on code in PR #4212: URL: https://github.com/apache/hadoop/pull/4212#discussion_r858421027 ########## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3ARequesterPays.java: ########## @@ -71,11 +72,16 @@ public void testRequesterPaysOptionSuccess() throws Throwable { inputStream.seek(0); inputStream.readByte(); - // Verify > 1 call was made, so we're sure it is correctly configured for each request - IOStatisticAssertions - .assertThatStatisticCounter(inputStream.getIOStatistics(), - StreamStatisticNames.STREAM_READ_OPENED) - .isGreaterThan(1); + if (conf.getBoolean(PREFETCH_ENABLED_KEY, true)) { + // For S3PrefetchingInputStream, verify a call was made + IOStatisticAssertions.assertThatStatisticCounter(inputStream.getIOStatistics(), + StreamStatisticNames.STREAM_READ_OPENED).isEqualTo(1); + } else { + // For S3InputStream, verify > 1 call was made, Review Comment: should this be For S3AInputStream ? ########## hadoop-tools/hadoop-aws/src/test/java/org/apache/hadoop/fs/s3a/ITestS3AUnbuffer.java: ########## @@ -192,6 +197,12 @@ private boolean isObjectStreamOpen(FSDataInputStream inputStream) { return ((S3AInputStream) inputStream.getWrappedStream()).isObjectStreamOpen(); } + private void skipIfCannotUnbuffer(InputStream inputStream) { Review Comment: You should just be able to use `inputStream.hasCapability(StreamCapabilities.UNBUFFER)` instead of this method Issue Time Tracking ------------------- Worklog Id: (was: 762181) Time Spent: 40m (was: 0.5h) > test failures with prefetching s3a input stream > ----------------------------------------------- > > Key: HADOOP-18175 > URL: https://issues.apache.org/jira/browse/HADOOP-18175 > Project: Hadoop Common > Issue Type: Sub-task > Components: fs/s3, test > Affects Versions: 3.4.0 > Reporter: Steve Loughran > Assignee: Monthon Klongklaew > Priority: Major > Labels: pull-request-available > Time Spent: 40m > Remaining Estimate: 0h > > identify and fix all test regressions from the prefetching s3a input stream -- This message was sent by Atlassian Jira (v8.20.7#820007) --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org