virajjasani commented on code in PR #4107:
URL: https://github.com/apache/hadoop/pull/4107#discussion_r859429956


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/tools/DFSAdmin.java:
##########
@@ -632,6 +638,20 @@ private static void 
printDataNodeReports(DistributedFileSystem dfs,
     }
   }
 
+  private static void printSlowDataNodeReports(DistributedFileSystem dfs, 
boolean listNodes,

Review Comment:
   > I suspect you would need some kind of header to distinguish from the other 
data node reports.
   
   This is called only if condition `listAll || listSlowNodes` is true:
   ```
       if (listAll || listSlowNodes) {
         printSlowDataNodeReports(dfs, listSlowNodes, "Slow");
       }
   ```
   
   Sample output:
   
   Header:
   ```
   -------------------------------------------------
   Slow datanodes (n):
   
   ```
   
   <img width="524" alt="Screenshot 2022-03-25 at 9 12 58 PM" 
src="https://user-images.githubusercontent.com/34790606/165455352-303eb506-0a5f-491d-ac44-bcc243a8f0f6.png";>
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to