raymondlam12 commented on code in PR #3344:
URL: https://github.com/apache/hadoop/pull/3344#discussion_r865386021
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -746,14 +747,18 @@ public AbfsRestOperation getPathStatus(final String path,
final boolean includeP
return op;
}
- public AbfsRestOperation read(final String path, final long position, final
byte[] buffer, final int bufferOffset,
- final int bufferLength, final String eTag,
String cachedSasToken,
+ public AbfsRestOperation read(String path,
+ byte[] buffer,
+ String cachedSasToken,
Review Comment:
What gets added to the ReadRequestParameters vs in this function signature
itself?
Should cachedSasToken be a member of the ReadRequestParameters as well?
Let's make sure these conventions are symmetrical across other
RequestParameters as well (ie. AppendRequestParameters).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
