monthonk commented on code in PR #3877: URL: https://github.com/apache/hadoop/pull/3877#discussion_r865918646
########## hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AFileSystem.java: ########## @@ -963,7 +965,15 @@ protected RequestFactory createRequestFactory() { // Any encoding type String contentEncoding = getConf().getTrimmed(CONTENT_ENCODING, null); - String storageClass = getConf().getTrimmed(STORAGE_CLASS, null); + StorageClass storageClass; + try { + String storageClassConf = getConf() + .getTrimmed(STORAGE_CLASS, "") + .toUpperCase(Locale.US); + storageClass = StorageClass.fromValue(storageClassConf); + } catch (IllegalArgumentException e) { + storageClass = null; Review Comment: sounds good, i will add some logging at warn to let users know that they should check storage class config -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org For additional commands, e-mail: common-issues-h...@hadoop.apache.org