steveloughran commented on PR #4284: URL: https://github.com/apache/hadoop/pull/4284#issuecomment-1120938219
-1. wontfix. if this were to go in * every pending PR would no longer apply without rebasing/reworking * every subsequent pr would be impossible to backport without reversing the work we have a fraction of this problem even with the movement of unshaded guava to shaded guava to hadoop's own Precondition classes; moving things from trunk to 3.3. to internal PRs always fail to merge at those two or three imports. we couldn't cope with this at scale. this is also why we don't go overboard in reordering imports in the files touched within a normal PR: IDEs may think they are being helpful by cleaning up imports, but aren't. Removing unused imports is fine, but big cleanups, tht causes too many problems. Sorry. if you had to deal with backporting you'd understand why. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
