slfan1989 commented on PR #4266: URL: https://github.com/apache/hadoop/pull/4266#issuecomment-1122448855
> > Hi @hchaverri , CC: @szilard-nemeth My local merge hchaverri code has passed the test, and his solution is feasible. Change the DelegationTokenSecretManagerMetrics into a global declaration, which can guarantee 1 initialization. > > I found out that he may have Blocking Java Doc compilation error, I try to solve it. > > JIRA:[issues.apache.org/jira/browse/HADOOP-18229](https://issues.apache.org/jira/browse/HADOOP-18229) [GitHub Pull Request #4292](https://github.com/apache/hadoop/pull/4292) > > I see, thanks for the update. How do you mean that Javadoc errors are "blocking"? I don't see a relation between the javadoc issues and the DelegationTokenSecretManagerMetrics issue. The latter causes unit tests to fail (maybe even production issues) so it should be fixed ASAP. Thanks. There is no problem with your understanding. I thought this patch was not merged because of the Java Doc Error (hadoop-yetus -1), but I carefully read the compilation information, Java Doc Compile Error IN JDK11，I support merge this patch（https://github.com/apache/hadoop/pull/4266）. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
