szilard-nemeth commented on code in PR #4165:
URL: https://github.com/apache/hadoop/pull/4165#discussion_r870206837
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-client/src/main/java/org/apache/hadoop/yarn/client/api/impl/AHSv2ClientImpl.java:
##########
@@ -137,9 +137,8 @@ public List<ContainerReport>
getContainers(ApplicationAttemptId
ApplicationId appId = applicationAttemptId.getApplicationId();
ApplicationReport appReport = getApplicationReport(appId);
Map<String, String> filters = new HashMap<>();
- filters.put("infofilters", "SYSTEM_INFO_PARENT_ENTITY eq {\"id\":\"" +
- applicationAttemptId.toString() +
- "\",\"type\":\"YARN_APPLICATION_ATTEMPT\"}");
+ filters.put("infofilters", "SYSTEM_INFO_PARENT_ENTITY eq "
+ + "{\"type\":\"YARN_APPLICATION_ATTEMPT\",\"id\":\"" +
applicationAttemptId + "\"}");
Review Comment:
Is this completely relying on the toString representation of
ApplicationAttemptId?
It's not a good practice to do so, if I understand it correctly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
