snvijaya commented on code in PR #3344:
URL: https://github.com/apache/hadoop/pull/3344#discussion_r870834429
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -746,14 +747,18 @@ public AbfsRestOperation getPathStatus(final String path,
final boolean includeP
return op;
}
- public AbfsRestOperation read(final String path, final long position, final
byte[] buffer, final int bufferOffset,
- final int bufferLength, final String eTag,
String cachedSasToken,
+ public AbfsRestOperation read(String path,
+ byte[] buffer,
+ String cachedSasToken,
Review Comment:
This refactoring is to ease the flow of other parameters that Fastpath
feature will enforce. Checkstyle has a limit on number of max arguments and we
will overrun it when feature code comes in.
Yes, its inline to AppendRequestParameters, where cachedsas doesnt flow
through this instance as its not a parameter to the function of reading/writing.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
