[
https://issues.apache.org/jira/browse/HADOOP-17872?focusedWorklogId=769359&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-769359
]
ASF GitHub Bot logged work on HADOOP-17872:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 11/May/22 23:44
Start Date: 11/May/22 23:44
Worklog Time Spent: 10m
Work Description: snvijaya commented on code in PR #3344:
URL: https://github.com/apache/hadoop/pull/3344#discussion_r870834429
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -746,14 +747,18 @@ public AbfsRestOperation getPathStatus(final String path,
final boolean includeP
return op;
}
- public AbfsRestOperation read(final String path, final long position, final
byte[] buffer, final int bufferOffset,
- final int bufferLength, final String eTag,
String cachedSasToken,
+ public AbfsRestOperation read(String path,
+ byte[] buffer,
+ String cachedSasToken,
Review Comment:
This refactoring is to ease the flow of other parameters that Fastpath
feature will enforce. Checkstyle has a limit on number of max arguments and we
will overrun it when feature code comes in.
Yes, its inline to AppendRequestParameters, where cachedsas doesnt flow
through this instance as its not a parameter to the function of reading/writing.
Issue Time Tracking
-------------------
Worklog Id: (was: 769359)
Time Spent: 1h 10m (was: 1h)
> ABFS: Refactor read flow to include ReadRequestParameter
> --------------------------------------------------------
>
> Key: HADOOP-17872
> URL: https://issues.apache.org/jira/browse/HADOOP-17872
> Project: Hadoop Common
> Issue Type: Sub-task
> Components: fs/azure
> Affects Versions: 3.4.0
> Reporter: Sneha Vijayarajan
> Assignee: Sneha Vijayarajan
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> This Jira is to facilitate upcoming work as part of adding an alternate
> connection :
> HADOOP-17853 ABFS: Enable optional store connectivity over azure specific
> protocol for data egress - ASF JIRA (apache.org)
> The scope of the change is to introduce a ReadRequestParameter that will
> include the various inputs needed for the read request to AbfsClient class.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
