slfan1989 commented on code in PR #4274:
URL: https://github.com/apache/hadoop/pull/4274#discussion_r871103561
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestFederationClientInterceptor.java:
##########
@@ -641,4 +643,18 @@ public void testGetApplicationsApplicationStateNotExists()
throws Exception{
Assert.assertNotNull(responseGet);
Assert.assertTrue(responseGet.getApplicationList().isEmpty());
}
+
+ @Test
+ public void testGetClusterNodesRequest() throws Exception {
+ LOG.info("Test FederationClientInterceptor : Get Cluster Nodeds request");
+ // null request
+ LambdaTestUtils.intercept(YarnException.class,
+ "Missing getClusterNodes request.", () ->
interceptor.getClusterNodes(null));
+
+ // normal request.
+ GetClusterNodesResponse response =
+ interceptor.getClusterNodes(GetClusterNodesRequest.newInstance());
+ Assert.assertEquals(subClusters.size(),
Review Comment:
I added unit tests related to getClusterNodes metrics in
TestRouterMetrics.java
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
