slfan1989 commented on code in PR #4274:
URL: https://github.com/apache/hadoop/pull/4274#discussion_r871917146
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/TestRouterMetrics.java:
##########
@@ -346,6 +346,11 @@ public void getClusterMetrics() {
LOG.info("Mocked: failed getClusterMetrics call");
metrics.incrGetClusterMetricsFailedRetrieved();
}
+
+ public void getClusterNodes() {
+ LOG.info("Mocked: failed getClusterNodes call");
Review Comment:
For the unit test of the Metric of getClusterNode, the test method is as
follows:
org.apache.hadoop.yarn.server.router.TestRouterMetrics#testGetClusterNodesFailed
Inside this method, bad SubCluster will change the value of FailedRetrieved,
badSubCluster is MockBadSubCluster, need to implement getClusterNodes
method, where you ask .
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscr...@hadoop.apache.org
For additional commands, e-mail: common-issues-h...@hadoop.apache.org
