ashutoshcipher commented on code in PR #4247: URL: https://github.com/apache/hadoop/pull/4247#discussion_r872905632
########## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml: ########## @@ -286,6 +286,13 @@ </description> </property> +<property> + <name>mapreduce.task.enable.ping-for-liveliness-check</name> + <value>true</value> Review Comment: Hi @iwasakims. I saw the comment from @cnauroth on JIRA about his suggestion to put it behind the configuration and I think we can keep it configurable and let the end user decide on it. By default, lets keep it ```mapreduce.task.enable.ping-for-liveliness-check : false``` which will keep the current behaviour intact and for use cases that we saw in JIRA, user can set it true when required Thoughts?/ ########## hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/resources/mapred-default.xml: ########## @@ -286,6 +286,13 @@ </description> </property> +<property> + <name>mapreduce.task.enable.ping-for-liveliness-check</name> + <value>true</value> Review Comment: Hi @iwasakims. I saw the comment from @cnauroth on JIRA about his suggestion to put it behind the configuration and I think we can keep it configurable and let the end user decide on it. By default, lets keep it ```mapreduce.task.enable.ping-for-liveliness-check : false``` which will keep the current behaviour intact and for use cases that we saw in JIRA, user can set it true when required Thoughts? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
