slfan1989 commented on PR #4292:
URL: https://github.com/apache/hadoop/pull/4292#issuecomment-1128904918

   Hi,@steveloughran @virajjasani @goiri , I have fixed hadoop-common javadoc 
compilation problem in jdk11, please help to review the code.
   
   my changes are as follows:
   
   1.modify the java doc configuration of the pom file, skip the proto file
   ```
   <plugin>
        <groupId>org.apache.maven.plugins</groupId>
        <artifactId>maven-javadoc-plugin</artifactId>
        <configuration>
            <sourceFileExcludes>
                 <sourceFileExclude>**/FSProtos.java</sourceFileExclude>
                 </sourceFileExcludes>
                 
<excludePackageNames>*.proto:*.tracing:*.protobuf</excludePackageNames>
        </configuration>
    </plugin>
   ```
   
   2.fix the warn and error problems, as follows:
   ```
   warning: no @param for in
   warning: no @return
   warning: no @throws for java.io.IOException
   warning: no description for @throws
   error: exception not thrown: java.io.IOException
   error: unknown tag: username
   error: bad use of '>'
   etc...
   ```
   
   hope these fixes will help hadoop project to be more complete, thanks!
   
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to