[
https://issues.apache.org/jira/browse/HADOOP-18236?focusedWorklogId=773226&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-773226
]
ASF GitHub Bot logged work on HADOOP-18236:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 22/May/22 14:22
Start Date: 22/May/22 14:22
Worklog Time Spent: 10m
Work Description: Hexiaoqiao commented on PR #4320:
URL: https://github.com/apache/hadoop/pull/4320#issuecomment-1133907833
@ZanderXu Thanks for your reply. I am +1 on the first sight. But there is
[one
comment](https://issues.apache.org/jira/browse/HADOOP-16028?focusedCommentId=16731763&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16731763)
leaved at [HADOOP-16028](https://issues.apache.org/jira/browse/HADOOP-16028)
however I can't recall why add read lock here once more.
cc @goiri @ayushtkn would you mind give another reviews. Thanks.
Issue Time Tracking
-------------------
Worklog Id: (was: 773226)
Time Spent: 1h (was: 50m)
> Remove duplicate locks in NetworkTopology
> -----------------------------------------
>
> Key: HADOOP-18236
> URL: https://issues.apache.org/jira/browse/HADOOP-18236
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: ZanderXu
> Assignee: ZanderXu
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 1h
> Remaining Estimate: 0h
>
> During reading the hadoop NetworkTopology.java, I suspect there is a
> duplicate lock.
> chooseRandom(line 532), and code is:
> {code:java}
> final int availableNodes;
> if (excludedScope == null) {
> availableNodes = countNumOfAvailableNodes(scope, excludedNodes);
> } else {
> netlock.readLock().lock();
> try {
> availableNodes = countNumOfAvailableNodes(scope, excludedNodes) -
> countNumOfAvailableNodes(excludedScope, excludedNodes);
> } finally {
> netlock.readLock().unlock();
> }
> } {code}
> All the places where called `chooseRandom` have the global read lock, so the
> internal read lock is duplicated.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
