slfan1989 commented on PR #4334: URL: https://github.com/apache/hadoop/pull/4334#issuecomment-1134690674
> > Hi, @steveloughran please help me to review the code, thank you very much! > > lwe have these things called "holidays" and "weekends". do not take the fact that i didn't review the change personally. > > it's mostly an HDFS source change. you need an hdfs jira for that bit of the patch. > > for hadoop common, why not move it to assertj the way we are doing for new code Thanks for your suggestion, I will re-submit a HDFS JIRA and make some adjustments to the code. Sorry for disturbing you during the holiday. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
