goiri commented on code in PR #4341:
URL: https://github.com/apache/hadoop/pull/4341#discussion_r881077343
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/clientrm/RouterYarnClientUtils.java:
##########
@@ -295,5 +297,25 @@ public static GetClusterNodeLabelsResponse
mergeClusterNodeLabelsResponse(
nodeLabelsResponse.setNodeLabelList(new ArrayList<>(nodeLabelsList));
return nodeLabelsResponse;
}
+
+ /**
+ * Merges a list of GetQueueUserAclsInfoResponse.
+ *
+ * @param responses a list of GetQueueUserAclsInfoResponse to merge.
+ * @return the merged GetQueueUserAclsInfoResponse.
+ */
+ public static GetQueueUserAclsInfoResponse mergeQueueUserAcls(
Review Comment:
Can we add some test here?
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/main/java/org/apache/hadoop/yarn/server/router/RouterMetrics.java:
##########
@@ -238,6 +255,16 @@ public long getNumSucceededAppAttemptReportRetrieved(){
return totalSucceededAppAttemptReportRetrieved.lastStat().numSamples();
}
+ @VisibleForTesting
+ public long getNumSucceededGetQueueUserAclsRetrieved(){
Review Comment:
Add tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
