slfan1989 commented on code in PR #4341:
URL: https://github.com/apache/hadoop/pull/4341#discussion_r881159169
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestFederationClientInterceptor.java:
##########
@@ -435,13 +437,10 @@ public void testGetApplicationEmptyRequest()
@Test
public void testGetApplicationAttemptReport()
throws YarnException, IOException, InterruptedException {
- LOG.info("Test FederationClientInterceptor: " +
- "Get ApplicationAttempt Report");
+ LOG.info("Test FederationClientInterceptor: Get ApplicationAttempt
Report.");
ApplicationId appId =
- ApplicationId.newInstance(System.currentTimeMillis(), 1);
- ApplicationAttemptId appAttemptId =
- ApplicationAttemptId.newInstance(appId, 1);
Review Comment:
ApplicationAttemptId needs to be queried in Yarn RM and cannot be generated
directly.
##########
hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-router/src/test/java/org/apache/hadoop/yarn/server/router/clientrm/TestFederationClientInterceptor.java:
##########
@@ -435,13 +437,10 @@ public void testGetApplicationEmptyRequest()
@Test
public void testGetApplicationAttemptReport()
throws YarnException, IOException, InterruptedException {
- LOG.info("Test FederationClientInterceptor: " +
- "Get ApplicationAttempt Report");
+ LOG.info("Test FederationClientInterceptor: Get ApplicationAttempt
Report.");
ApplicationId appId =
- ApplicationId.newInstance(System.currentTimeMillis(), 1);
- ApplicationAttemptId appAttemptId =
- ApplicationAttemptId.newInstance(appId, 1);
Review Comment:
ApplicationAttemptId needs to be queried in yarn and cannot be generated
directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
