ayushtkn commented on PR #4320: URL: https://github.com/apache/hadoop/pull/4320#issuecomment-1137686111
Logically from the present code flow this lock is redundant and there is enough discussion on the original jira, this was kept because the method calling was protected and a comment there confirms that it is indeed deliberate https://issues.apache.org/jira/browse/HADOOP-16028?focusedCommentId=16731433&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-16731433 I don't think we can change this access modifier to private for compat reasons and the reason for which it was done then still holds true -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
