ZanderXu commented on code in PR #4360:
URL: https://github.com/apache/hadoop/pull/4360#discussion_r883193453


##########
hadoop-hdfs-project/hadoop-hdfs/src/main/resources/hdfs-default.xml:
##########
@@ -3003,10 +3003,10 @@
 </property>
 
 <property>
-  <name>dfs.datanode.fsdatasetasyncdisk.max.threads.per.volume</name>
-  <value>4</value>
+  <name>dfs.datanode.fsdatasetasyncdisk.core.threads.per.volume</name>
+  <value>1</value>
   <description>
-    The maximum number of threads per volume used to process async disk
+    The number of core threads per volume used to process async disk

Review Comment:
   @saintstack Thanks for your comment.
   
   > During bulk delete, the executor did not blossom up to the max number of 
threads per volume? Upping the max wouldn't help w/ your case?
   
   The threadPoolExecutor used one unbounded LinkedBlockingQueue, so the 
executor will not blossom up to the max number of threads per volume, and 
upping the max wouldn't help this case.
   
   
   Because the threadPoolExecutor use one unbounded LinkedBlockingQueue, so I 
want to set the maximum number of threads same with the number of core threads.
   
   Do you have any good suggestions?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to