tomscut commented on code in PR #4357:
URL: https://github.com/apache/hadoop/pull/4357#discussion_r884077287
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestSlowPeerTracker.java:
##########
@@ -79,9 +79,12 @@ public void testEmptyReports() {
@Test
public void testReportsAreRetrieved() {
- tracker.addReport("node2", "node1", 1.2);
- tracker.addReport("node3", "node1", 2.1);
- tracker.addReport("node3", "node2", 1.22);
+ OutlierMetrics outlierMetrics1 = new OutlierMetrics(0.0, 0.0, 0.0, 1.2);
Review Comment:
Can we not define a variable `outlierMetrics1` here, just to make it a
little bit cleaner.
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/blockmanagement/TestSlowPeerTracker.java:
##########
@@ -161,17 +176,28 @@ public void testGetJson() throws IOException {
@Test
public void testGetJsonSizeIsLimited() throws IOException {
- tracker.addReport("node1", "node2", 1.634);
- tracker.addReport("node1", "node3", 2.3566);
- tracker.addReport("node2", "node3", 3.869);
- tracker.addReport("node2", "node4", 4.1356);
- tracker.addReport("node3", "node4", 1.73057);
- tracker.addReport("node3", "node5", 2.4956730);
- tracker.addReport("node4", "node6", 3.29847);
- tracker.addReport("node5", "node6", 4.13444);
- tracker.addReport("node5", "node7", 5.10845);
- tracker.addReport("node6", "node8", 2.37464);
- tracker.addReport("node6", "node7", 1.29475656);
+ OutlierMetrics outlierMetrics1 = new OutlierMetrics(0.0, 0.0, 0.0, 1.634);
Review Comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
