[
https://issues.apache.org/jira/browse/HADOOP-7974?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186418#comment-13186418
]
Hadoop QA commented on HADOOP-7974:
-----------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12510616/HADOOP-7974.patch
against trunk revision .
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
-1 javadoc. The javadoc tool appears to have generated 7 warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 eclipse:eclipse. The patch built with eclipse:eclipse.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed unit tests in .
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-HADOOP-Build/509//testReport/
Console output:
https://builds.apache.org/job/PreCommit-HADOOP-Build/509//console
This message is automatically generated.
> TestViewFsTrash incorrectly determines the user's home directory
> ----------------------------------------------------------------
>
> Key: HADOOP-7974
> URL: https://issues.apache.org/jira/browse/HADOOP-7974
> Project: Hadoop Common
> Issue Type: Bug
> Components: fs
> Affects Versions: 0.23.1
> Reporter: Eli Collins
> Assignee: Harsh J
> Attachments: HADOOP-7974.patch
>
>
> HADOOP-7284 added a test called TestViewFsTrash which contains the following
> code to determine the user's home directory. It only works if the user's
> directory is one level deep, and breaks if the home directory is more than
> one level deep (eg user hudson, who's home dir might be /usr/lib/hudson
> instead of /home/hudson).
> {code}
> // create a link for home directory so that trash path works
> // set up viewfs's home dir root to point to home dir root on target
> // But home dir is different on linux, mac etc.
> // Figure it out by calling home dir on target
>
> String homeDir = fsTarget.getHomeDirectory().toUri().getPath();
> int indexOf2ndSlash = homeDir.indexOf('/', 1);
> String homeDirRoot = homeDir.substring(0, indexOf2ndSlash);
> ConfigUtil.addLink(conf, homeDirRoot,
> fsTarget.makeQualified(new Path(homeDirRoot)).toUri());
> ConfigUtil.setHomeDirConf(conf, homeDirRoot);
> Log.info("Home dir base " + homeDirRoot);
> {code}
> Seems like we should instead search from the end of the path for the last
> slash and use that as the base, ie ask the home directory for its parent.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
