[
https://issues.apache.org/jira/browse/HADOOP-7956?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186434#comment-13186434
]
Harsh J commented on HADOOP-7956:
---------------------------------
I like #2.
#1 has a chance of breaking some behavior, given our _reconfiguration_ history.
One I can think of, and came up recently from Koji on the ML, is the MR child
opts vs. map/reduce specific child opts -- if both get present in default.xml,
then it voids the former, breaking behavior even if the user wants to specify
it.
> Remove duplicate definition of default config values
> ----------------------------------------------------
>
> Key: HADOOP-7956
> URL: https://issues.apache.org/jira/browse/HADOOP-7956
> Project: Hadoop Common
> Issue Type: Improvement
> Components: conf
> Reporter: Eli Collins
>
> We define default configuration values in two places:
> #1 The default.xml files (eg core-default.xml)
> #2 The _DEFAULT defines in *Keys.java
> This means the defaults used in the code may or may not be dead code based on
> whether the config is present in the default xml file. Would be good to
> define these in one place. Eg:
> #1 Just have the defines in the code and figure out how to make those
> accessible as a loadable resource (eg could generate the default files from
> the defines in the KeysPublic* files)
> #2 Remove one of the definitions entirely (possible to live w/o the default
> files?) or
> #3 Remove the overlap between the code and default files
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
