GauthamBanasandra commented on code in PR #4374: URL: https://github.com/apache/hadoop/pull/4374#discussion_r885004201
########## hadoop-hdfs-project/hadoop-hdfs-native-client/src/main/native/libhdfspp/CMakeLists.txt: ########## @@ -53,30 +53,14 @@ find_package(Threads) include(CheckCXXSourceCompiles) include(CheckSymbolExists) -# Download and build gtest -configure_file(CMakeLists-gtest.txt.in googletest-download/CMakeLists.txt) Review Comment: In the old approach (which uses `configure_file`), CMake would first clone the gtest repo and then checkout the release tag `release-1.10.0`. I believe, something has changed in the manner through which the repo is cloned which is causing the `release-1.10.0` tag to abscond. In the approach proposed by this PR, we do away with the clone and checkout steps, since we get the gtest source code at `release-1.10.0` directly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
