[
https://issues.apache.org/jira/browse/HADOOP-18269?focusedWorklogId=776107&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-776107
]
ASF GitHub Bot logged work on HADOOP-18269:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 31/May/22 06:55
Start Date: 31/May/22 06:55
Worklog Time Spent: 10m
Work Description: GuoPhilipse commented on PR #4216:
URL: https://github.com/apache/hadoop/pull/4216#issuecomment-1141735915
Thanks @steveloughran for your review and merge~
Issue Time Tracking
-------------------
Worklog Id: (was: 776107)
Time Spent: 2.5h (was: 2h 20m)
> Misleading method name in DistCpOptions
> ---------------------------------------
>
> Key: HADOOP-18269
> URL: https://issues.apache.org/jira/browse/HADOOP-18269
> Project: Hadoop Common
> Issue Type: Improvement
> Components: tools/distcp
> Affects Versions: 3.3.2
> Reporter: guophilipse
> Assignee: guophilipse
> Priority: Minor
> Labels: pull-request-available
> Fix For: 3.3.4
>
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> Currently method in DistCpOptions withCRC was used as the following
> ```
> withCRC(true) means check without crc
> withCRC(false) means check with crc
> ```
> which mislead the developer when we pass the paramter, we can rename the
> method to clear that.after that it should be:
> ```
> withSkipCRC(true) means check without crc
> withSkipCRC(false) means check with crc
> ```
> so it will be more understandable.
>
>
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
