[ https://issues.apache.org/jira/browse/HADOOP-18232 ]


    Steve Loughran deleted comment on HADOOP-18232:
    -----------------------------------------

was (Author: [email protected]):
please, no. this may seem a nice minor cleanup, but it makes backporting a 
nightmare. all to often we need to cherrypick patches across branches, and when 
more than one patch touches the same imports, or just imports nearby, those of 
us doing the work are left doing merges across three versions.

even the move to different guava imports (com.google, hadoop.thirdparty, 
internal reimplementations) is a pain, and there we only change the classname, 
not any movement of the declarations.

I am going to block this as "not worth the pain". 

> [Umbrella] Remove unused Imports in hadoop project
> --------------------------------------------------
>
>                 Key: HADOOP-18232
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18232
>             Project: Hadoop Common
>          Issue Type: Improvement
>            Reporter: Ashutosh Gupta
>            Assignee: Ashutosh Gupta
>            Priority: Major
>              Labels: pull-request-available
>          Time Spent: 1h 40m
>  Remaining Estimate: 0h
>
> h3. Optimize Imports to keep code clean
>  # Remove any unused imports
>  # -Sort the import statements.-
>  # -Remove .* imports-



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to