jianghuazhu commented on PR #3376: URL: https://github.com/apache/hadoop/pull/3376#issuecomment-1144654653
Hi @prasad-acit , nice to talk to you. For delete using FGL, it may be safer to add child locks before fsn.removeLeasesAndINodes().  The reason here is that after finishing running unprotectedDelete(), there are still updated content, such as block-related updates, and snapshotManager deletes Snapshottable. Before this, this was done while holding the FSNamesystemLock. Based on the premise of safety, I make my proposal. If my suggestion is wrong, please ignore it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
