zhengchenyu commented on code in PR #4314: URL: https://github.com/apache/hadoop/pull/4314#discussion_r889778464
########## hadoop-yarn-project/hadoop-yarn/hadoop-yarn-server/hadoop-yarn-server-web-proxy/src/test/java/org/apache/hadoop/yarn/server/webproxy/TestWebAppProxyServerFed.java: ########## @@ -0,0 +1,29 @@ +/** + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with this + * work for additional information regarding copyright ownership. The ASF + * licenses this file to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance with the License. + * You may obtain a copy of the License at + * <p> + * http://www.apache.org/licenses/LICENSE-2.0 + * <p> + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, WITHOUT + * WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the + * License for the specific language governing permissions and limitations under + * the License. + */ + +package org.apache.hadoop.yarn.server.webproxy; + +import org.apache.hadoop.yarn.conf.YarnConfiguration; + +public class TestWebAppProxyServerFed extends TestWebAppProxyServer { + + @Override + public void setUp() throws Exception { + super.setUp(); + conf.setBoolean(YarnConfiguration.FEDERATION_ENABLED, true); Review Comment: It's only for test the basic function (For example: start or stop and so on) of WebAppProxyServer in federation mode. For me, I think TestWebAppProxyServer is not generic enough, because that UT only test start, stop and bindaddress. I don't know whether is necessary to add some integration testing so that we can test proxy app web link? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
