[
https://issues.apache.org/jira/browse/HADOOP-7972?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13186738#comment-13186738
]
Aaron T. Myers commented on HADOOP-7972:
----------------------------------------
I'm not crazy about this design. Rather than add a helper class with a bunch of
static methods, and make sure that everyone calls the static methods of that
class passing an HAServiceProtocol proxy object, I think it might be better to
add something like an HAServiceClient class which has all the same methods as
the HAServiceProtocol interface, but delegates to an underlying proxy object
and unwraps all remote exceptions. This seems more OOPy, and is more in line
with the way, for example, DFSClient wraps a ClientProtocol proxy object and
unwraps/rethrows all remote exceptions.
What do you guys think?
> HAServiceProtocol exceptions need to be unwrapped before it can be used
> -----------------------------------------------------------------------
>
> Key: HADOOP-7972
> URL: https://issues.apache.org/jira/browse/HADOOP-7972
> Project: Hadoop Common
> Issue Type: Bug
> Components: ha
> Affects Versions: HA Branch (HDFS-1623)
> Reporter: Hari Mankude
> Assignee: Hari Mankude
> Attachments: HADOOP-7972.txt, HADOOP-7972.txt
>
>
> Remote exceptions for all the interfaces in HAServiceProtocol class has to be
> unwrapped before it can be used. All the HAServiceProtocol interfaces throw
> exceptions of type RemoteException by default.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
