Hexiaoqiao commented on PR #4366: URL: https://github.com/apache/hadoop/pull/4366#issuecomment-1148627690
> getReplicaInfo(ExtendedBlock b) will check gs, and getReplicaInfo(String bpid, long blkid) will not check the gs. @ZanderXu Thanks for the great catch here. > I would like to ask a question, after reading your discussion, is it possible that block GS of client may be smaller than DN appears in all places where getReplicaInfo(String bpid, long blkid) is called? It is good question. IMO, it is not necessary to compare GS for any cases when get fine-grained lock for BLOCK_POOl or VOLUME, because both of them are not depended on block. Just suggest to improve them together in one PR. Thanks again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
