Hexiaoqiao commented on PR #4367: URL: https://github.com/apache/hadoop/pull/4367#issuecomment-1148648304
@ZanderXu Thanks for the great catch here. It is indeed missed method which need to improve. cc @MingXiangLi @ZanderXu would you mind to check if other methods also leave this issues? > Thank you for your contribution, but I still have some concerns about [HDFS-16534](https://issues.apache.org/jira/browse/HDFS-16534). I feel that for a new feature, multiple prs should not be used to fix the problem separately, which makes the code very difficult to read. I recommend creating it under [HDFS-15382](https://issues.apache.org/jira/browse/HDFS-15382) A subtask to fix [HDFS-16598](https://issues.apache.org/jira/browse/HDFS-16598) and [HDFS-16600](https://issues.apache.org/jira/browse/HDFS-16600) together. @slfan1989 Thansk for your suggestions. IMO, this is not the blocker issue. Any tickets will be collected to subtask of HDFS-16534 before checkin for committers. -1 to combine HDFS-16598 and HDFS-16600 together. IIUC, it is recommended to add/fix one issue for one ticket. Welcome to any more discussions. @ZanderXu @slfan1989 Thanks again. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
