ahmarsuhail commented on code in PR #4386:
URL: https://github.com/apache/hadoop/pull/4386#discussion_r893679145
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/read/S3File.java:
##########
@@ -193,18 +203,7 @@ public InputStream openForRead(long offset, int size)
throws IOException {
return stream;
}
- /**
- * Closes this stream and releases all acquired resources.
- */
- @Override
- public synchronized void close() {
- List<InputStream> streams = new
ArrayList<InputStream>(this.s3Objects.keySet());
- for (InputStream stream : streams) {
- this.close(stream);
- }
- }
-
- void close(InputStream inputStream) {
+ void close(InputStream inputStream, int numRemainingBytes) {
Review Comment:
nope, it's used by S3Reader
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
