[
https://issues.apache.org/jira/browse/HADOOP-18231?focusedWorklogId=780018&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-780018
]
ASF GitHub Bot logged work on HADOOP-18231:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 09/Jun/22 15:47
Start Date: 09/Jun/22 15:47
Worklog Time Spent: 10m
Work Description: ahmarsuhail commented on code in PR #4386:
URL: https://github.com/apache/hadoop/pull/4386#discussion_r893679145
##########
hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/read/S3File.java:
##########
@@ -193,18 +203,7 @@ public InputStream openForRead(long offset, int size)
throws IOException {
return stream;
}
- /**
- * Closes this stream and releases all acquired resources.
- */
- @Override
- public synchronized void close() {
- List<InputStream> streams = new
ArrayList<InputStream>(this.s3Objects.keySet());
- for (InputStream stream : streams) {
- this.close(stream);
- }
- }
-
- void close(InputStream inputStream) {
+ void close(InputStream inputStream, int numRemainingBytes) {
Review Comment:
nope, it's used by S3Reader
Issue Time Tracking
-------------------
Worklog Id: (was: 780018)
Time Spent: 3h 40m (was: 3.5h)
> tests in ITestS3AInputStreamPerformance are failing
> ----------------------------------------------------
>
> Key: HADOOP-18231
> URL: https://issues.apache.org/jira/browse/HADOOP-18231
> Project: Hadoop Common
> Issue Type: Sub-task
> Reporter: Ahmar Suhail
> Assignee: Ahmar Suhail
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> The following tests are failing when prefetching is enabled:
> testRandomIORandomPolicy - expects stream to be opened 4 times (once for
> every random read), but prefetching will only open twice.
> testDecompressionSequential128K - expects stream to be opened once, but
> prefetching will open once for each block the file has. landsat file used in
> the test has size 42MB, prefetching block size = 8MB, expected open count is
> 6.
> testReadWithNormalPolicy - same as above.
> testRandomIONormalPolicy - executes random IO, but with a normal policy.
> S3AInputStream will abort the stream and change the policy, prefetching
> handles random IO by caching blocks so doesn't do any of that.
> testRandomReadOverBuffer - multiple assertions failing here, also depends a
> lot on readAhead values, not very relevant for prefetching
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
