[
https://issues.apache.org/jira/browse/HADOOP-18288?focusedWorklogId=781532&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-781532
]
ASF GitHub Bot logged work on HADOOP-18288:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 15/Jun/22 08:30
Start Date: 15/Jun/22 08:30
Worklog Time Spent: 10m
Work Description: steveloughran commented on code in PR #4431:
URL: https://github.com/apache/hadoop/pull/4431#discussion_r897690828
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestConsistentReadsObserver.java:
##########
@@ -123,7 +123,7 @@ public void testRequeueCall() throws Exception {
+ CommonConfigurationKeys.IPC_BACKOFF_ENABLE, true);
NameNodeAdapter.getRpcServer(nn).refreshCallQueue(configuration);
- assertEquals(1, NameNodeAdapter.getRpcServer(nn).getTotalRequests());
+ assertTrue(NameNodeAdapter.getRpcServer(nn).getTotalRequests() > 0);
Review Comment:
if you have an assertion where a useful message isn't autogenerated the way
assertequals does, afraid you will need to add a message *or* use assertJ to
describe the assert. sorry.
Issue Time Tracking
-------------------
Worklog Id: (was: 781532)
Time Spent: 1h 10m (was: 1h)
> Total requests and total requests per sec served by RPC servers
> ---------------------------------------------------------------
>
> Key: HADOOP-18288
> URL: https://issues.apache.org/jira/browse/HADOOP-18288
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Viraj Jasani
> Assignee: Viraj Jasani
> Priority: Major
> Labels: pull-request-available
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> RPC Servers provide bunch of useful information like num of open connections,
> slow requests, num of in-progress handlers, RPC processing time, queue time
> etc, however so far it doesn't provide accumulation of all requests as well
> as current snapshot of requests per second served by the server. Exposing
> them would benefit from operational viewpoint in identifying how busy the
> servers have been and how much load they are currently serving in the
> presence of cluster wide high load.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
