virajjasani commented on code in PR #4431:
URL: https://github.com/apache/hadoop/pull/4431#discussion_r898341425
##########
hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/server/namenode/ha/TestConsistentReadsObserver.java:
##########
@@ -123,7 +123,7 @@ public void testRequeueCall() throws Exception {
+ CommonConfigurationKeys.IPC_BACKOFF_ENABLE, true);
NameNodeAdapter.getRpcServer(nn).refreshCallQueue(configuration);
- assertEquals(1, NameNodeAdapter.getRpcServer(nn).getTotalRequests());
+ assertTrue(NameNodeAdapter.getRpcServer(nn).getTotalRequests() > 0);
Review Comment:
I agree, this is bit painful for debugging purpose. Updated with assertJ as
it has better APIs to deal with such conditions
(`assertThat(x).isGreaterThan(y)`).
Updated with the same, thanks for the suggestion @steveloughran
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
