mehakmeet commented on PR #4352: URL: https://github.com/apache/hadoop/pull/4352#issuecomment-1157264920
Thanks for the review @steveloughran, sorry couldn't address anything until now(got little ill) > main comment is that the thread's statistic aggregator should be fetched/stored in constructor, not in close Got your point, so just one concern on that, should the IOStatisticsContext be a static instance in the S3AFileSystem, and we just pass on the iostatisticsAggregator to the streams, since we would still require the context in the streams to update the WeakReferenceThreadMap after the aggregation, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
