jojochuang commented on code in PR #4252:
URL: https://github.com/apache/hadoop/pull/4252#discussion_r899627843
##########
hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/protocolPB/PBHelper.java:
##########
@@ -1040,11 +1040,16 @@ public static BlockECReconstructionInfo
convertBlockECReconstructionInfo(
byte[] liveBlkIndices =
blockEcReconstructionInfoProto.getLiveBlockIndices()
.toByteArray();
+ byte[] excludeReconstructedIndices =
Review Comment:
Please check and make sure ExcludeReconstructedIndices is filled.
##########
hadoop-hdfs-project/hadoop-hdfs-client/src/main/proto/erasurecoding.proto:
##########
@@ -108,6 +108,7 @@ message BlockECReconstructionInfoProto {
required StorageTypesProto targetStorageTypes = 5;
required bytes liveBlockIndices = 6;
required ErasureCodingPolicyProto ecPolicy = 7;
+ required bytes excludeReconstructedIndices = 8;
Review Comment:
```suggestion
optional bytes excludeReconstructedIndices = 8;
```
Make it optional to ensure backward compatibility.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
