szilard-nemeth commented on PR #4439: URL: https://github.com/apache/hadoop/pull/4439#issuecomment-1158561298
Hi @brumi1024 , @9uapaw , I think I fixed all your concerns, please check the latest code again. I also fixed the javac, blanks and checkstyle issues. Some of the checkstyle issues I haven't fixed and I don't plan to fix them either: 1. In LogAggregationTestcaseBuilder, all fields are package-private and they all generate warnings, like: ``` ./hadoop-yarn-project/hadoop-yarn/hadoop-yarn-common/src/test/java/org/apache/hadoop/yarn/logaggregation/testutils/LogAggregationTestcaseBuilder.java:29: final long now;:14: Variable 'now' must be private and have accessor methods. [VisibilityModifier] ``` I don't think we need to fix those. 2. Same as 1., but for the class AppDescriptor 3. Same as 1., but for the class PathWithFileStatus -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
