mehakmeet commented on code in PR #4331:
URL: https://github.com/apache/hadoop/pull/4331#discussion_r900688136
##########
hadoop-tools/hadoop-azure/src/main/java/org/apache/hadoop/fs/azurebfs/services/AbfsClient.java:
##########
@@ -531,13 +538,37 @@ public Pair<AbfsRestOperation, Boolean> renamePath(
url,
requestHeaders);
try {
+ incrementAbfsRenamePath();
op.execute(tracingContext);
- return Pair.of(op, false);
+ // AbfsClientResult contains the AbfsOperation, If recovery happened or
+ // not, and the incompleteMetaDataState is true or false.
+ return new AbfsClientResult(op, isMetadataIncompleteState ? true :
false, isMetadataIncompleteState);
Review Comment:
`return new AbfsClientResult(op, isMetadataIncompleteState,
isMetadataIncompleteState);` this is exactly what I was returning, but, the
only reason I am using a ternary op here, was to make the code more readable in
the sense that "Rename recovery" is true when we have successfully renamed and
isMetadataIncompleteState is true, else false.
I will revert it back to `(op, isMetadataIncompleteState,
isMetadataIncompleteState);` and add the comment. But this looked little
confusing 😄.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
