[ 
https://issues.apache.org/jira/browse/HADOOP-18300?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17555913#comment-17555913
 ] 

Ayush Saxena edited comment on HADOOP-18300 at 6/18/22 1:56 PM:
----------------------------------------------------------------

bq. our GSON version is from ~3 years ago. update to latest release.

That isn't a good reason for upgrading a thirdparty lib, considering these 
thirdparty libs usually makes upgrades of downstream projects a pain. Better to 
have some concrete good reason to do so, some relevant to us improvement/bug 
fix.

bq. try to check release notes to see if this is incompatible.
Do you mean to say you tried to check the release notes and concluded it isn't 
incompatible, then ignore everything I am ok bumping this version up.
or Do you mean reviewer should find then check & figure out if there is 
anything incompatible or not from the release notes?

Side Note: Please don't put the Fix Version, that is for a committer to set 
once he commits the patch for the release notes to pick this, Target/Affect 
version can be used by others, I am removing that


was (Author: ayushtkn):
bq. our GSON version is from ~3 years ago. update to latest release.

That isn't a good reason for upgrading a thirdparty lib, considering these 
thirdparty libs usually makes upgrades of downstream projects a pain. Better to 
have some concrete good reason to do so, some relevant to us improvement/bug 
fix.

bq. try to check release notes to see if this is incompatible.
Do you mean to say you tried to check the release notes and concluded it isn't 
incompatible, then ignore everything I am ok bumping this version up.
or Do you mean reviewer should find then check & figure out if there is 
anything incompatible or not from the release notes?

> Update GSON to 2.9.0
> --------------------
>
>                 Key: HADOOP-18300
>                 URL: https://issues.apache.org/jira/browse/HADOOP-18300
>             Project: Hadoop Common
>          Issue Type: Task
>          Components: build
>            Reporter: Igor Dvorzhak
>            Assignee: Igor Dvorzhak
>            Priority: Minor
>              Labels: pull-request-available
>             Fix For: 3.4.0, 3.3.2, 3.2.4
>
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> our GSON version is from ~3 years ago. update to latest release.
> try to check release notes to see if this is incompatible.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to