[
https://issues.apache.org/jira/browse/HADOOP-18306?focusedWorklogId=783111&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-783111
]
ASF GitHub Bot logged work on HADOOP-18306:
-------------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jun/22 18:17
Start Date: 20/Jun/22 18:17
Worklog Time Spent: 10m
Work Description: umamaheswararao commented on code in PR #4474:
URL: https://github.com/apache/hadoop/pull/4474#discussion_r901921272
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java:
##########
@@ -215,7 +215,13 @@ private Set<String> getUnixGroups(String user) throws
IOException {
groups = resolvePartialGroupNames(user, e.getMessage(),
executor.getOutput());
} catch (PartialGroupNameException pge) {
- LOG.warn("unable to return groups for user {}", user, pge);
+ if(LOG.isDebugEnabled()) {
Review Comment:
@smengcl do you think this is fine? or we don't need this in even in Warn?
we were hitting this log message. This current patch voids the full trace in
logs when debug is not enabled.
##########
hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ShellBasedUnixGroupsMapping.java:
##########
@@ -215,7 +215,13 @@ private Set<String> getUnixGroups(String user) throws
IOException {
groups = resolvePartialGroupNames(user, e.getMessage(),
executor.getOutput());
} catch (PartialGroupNameException pge) {
- LOG.warn("unable to return groups for user {}", user, pge);
+ if(LOG.isDebugEnabled()) {
Review Comment:
can we just extract this into String msg = ""unable to return groups for
user {}" and use this msg to make log line looks clean?
Issue Time Tracking
-------------------
Worklog Id: (was: 783111)
Time Spent: 20m (was: 10m)
> Warnings should not be shown on cli console when linux user not present on
> client
> ---------------------------------------------------------------------------------
>
> Key: HADOOP-18306
> URL: https://issues.apache.org/jira/browse/HADOOP-18306
> Project: Hadoop Common
> Issue Type: New Feature
> Reporter: Swaminathan Balachandran
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 20m
> Remaining Estimate: 0h
>
> {code:java}
> {code}
> {noformat}
> 22/04/26 10:51:18 WARN security.ShellBasedUnixGroupsMapping: unable to return
> groups for user om
> PartialGroupNameException The user name 'om' is not found. id: ‘om’: no such
> user
> id: ‘om’: no such user
> at
> org.apache.hadoop.security.ShellBasedUnixGroupsMapping.resolvePartialGroupNames(ShellBasedUnixGroupsMapping.java:291)
> at
> org.apache.hadoop.security.ShellBasedUnixGroupsMapping.getUnixGroups(ShellBasedUnixGroupsMapping.java:215)
> at
> org.apache.hadoop.security.ShellBasedUnixGroupsMapping.getGroupsSet(ShellBasedUnixGroupsMapping.java:123)
> at
> org.apache.hadoop.security.Groups$GroupCacheLoader.fetchGroupSet(Groups.java:413)
> at
> org.apache.hadoop.security.Groups$GroupCacheLoader.load(Groups.java:351)
> at
> org.apache.hadoop.security.Groups$GroupCacheLoader.load(Groups.java:300)
> at
> com.google.common.cache.LocalCache$LoadingValueReference.loadFuture(LocalCache.java:3529)
> at
> com.google.common.cache.LocalCache$Segment.loadSync(LocalCache.java:2278)
> at
> com.google.common.cache.LocalCache$Segment.lockedGetOrLoad(LocalCache.java:2155)
> at com.google.common.cache.LocalCache$Segment.get(LocalCache.java:2045)
> at com.google.common.cache.LocalCache.get(LocalCache.java:3962)
> at com.google.common.cache.LocalCache.getOrLoad(LocalCache.java:3985)
> at
> com.google.common.cache.LocalCache$LocalLoadingCache.get(LocalCache.java:4946)
> at org.apache.hadoop.security.Groups.getGroupInternal(Groups.java:258)
> at org.apache.hadoop.security.Groups.getGroupsSet(Groups.java:230)
> at
> org.apache.hadoop.security.UserGroupInformation.getGroupsSet(UserGroupInformation.java:1760)
> at
> org.apache.hadoop.security.UserGroupInformation.getPrimaryGroupName(UserGroupInformation.java:1603)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneClientAdapterImpl.getGroupName(BasicRootedOzoneClientAdapterImpl.java:992)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneClientAdapterImpl.getFileStatusAdapterForVolume(BasicRootedOzoneClientAdapterImpl.java:1016)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneClientAdapterImpl.getFileStatus(BasicRootedOzoneClientAdapterImpl.java:574)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneFileSystem.getFileStatus(BasicRootedOzoneFileSystem.java:858)
> at org.apache.hadoop.fs.Globber.getFileStatus(Globber.java:115)
> at org.apache.hadoop.fs.Globber.doGlob(Globber.java:349)
> at org.apache.hadoop.fs.Globber.glob(Globber.java:202)
> at org.apache.hadoop.fs.FileSystem.globStatus(FileSystem.java:2106)
> at
> org.apache.hadoop.fs.ozone.BasicRootedOzoneFileSystem.globStatus(BasicRootedOzoneFileSystem.java:915)
> at org.apache.hadoop.fs.shell.PathData.expandAsGlob(PathData.java:353)
> at org.apache.hadoop.fs.shell.Command.expandArgument(Command.java:250)
> at org.apache.hadoop.fs.shell.Command.expandArguments(Command.java:233)
> at
> org.apache.hadoop.fs.shell.FsCommand.processRawArguments(FsCommand.java:104)
> at org.apache.hadoop.fs.shell.Command.run(Command.java:177)
> at org.apache.hadoop.fs.FsShell.run(FsShell.java:328)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:76)
> at org.apache.hadoop.util.ToolRunner.run(ToolRunner.java:90)
> at org.apache.hadoop.fs.ozone.OzoneFsShell.main(OzoneFsShell.java:83)
> {noformat}
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
