mehakmeet commented on PR #4383: URL: https://github.com/apache/hadoop/pull/4383#issuecomment-1162621569
few small nits here - You have added "." at the end of every line in javadocs, it should only be at the end of a sentence or end of the javadoc, not each line. - Some of the methods in AuditTool have wrong access modifiers, if you're not using a method outside this class just keep them private. - I have one doubt about putting the auditTool in the Hadoop shell script. Since, at the moment this is hadoop-aws specific tool, not sure if defining the command in hadoop-common is the right move. Can you check and see where s3guard tool's command is defined in hadoop-aws, that might be a more appropriate place for hadoop-aws specific shell commands. After these, this LGTM. CC: @mukund-thakur @steveloughran to review and merge. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
